Merged
Conversation
Collaborator
|
Huge +1. |
Member
Author
|
The CI failures are pyright being angry about the GUI again. |
Member
Author
|
We can still merge this if we want, but the platformer tutorial still references |
Member
|
There's no reasons to have simplecamera with carmera2d |
Member
|
Good stuff 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
SimpleCamerafromarcade.camera's__init__.pysimple_camera.pyfile itselfWhy
TL;DR: We'd have to rewrite
SimpleCameraagain + Discord discussion suggests nobody actually wants SimpleCamera aroundIt's Not Actually 2.6 Compatible
The current

SimpleCameraisn't API-compatible with 2.6. Instead, it's a rewrite of a rewrite started before 3.0. See the blue forks on this timeline (credit goes to @DigiDuncan):Green is
development, yellow appears to be WIP codeNothing Actually Uses It
arcade.cameraCamera2D.from_raw_datais the best porting optionTL;DR: Add migration guide showing how to convert code to use the class method
SimpleCameraFails to Delivermove_to/updatemethodsupdatedoesn't accept a time stepOther compatibility approaches were disliked
The following options were disliked in Discord discussion:
Camerawhich acts like 2.6 but logs deprecation warning to consoleCameraimport raises anImportErroron use + links a migration guide