Eliminate pyright errors#2062
Merged
eruvanos merged 33 commits intopythonarcade:developmentfrom Apr 15, 2024
Merged
Conversation
Member
|
Thanks for the contribution. @pushfoo Is this ready to merge? For me it looks fine, the new functionality within Rect seems to be useful and the AsFloat makes the usage of values clear. |
Member
Author
|
TL;DR: Give it a look over on Mac and Windows for the text scrolling text and text drawing examples? I just went through those examples under Linux. It looks fine here as far as a quick glance can tell. @DigiDuncan @DragonMoffon could you two help out look at those examples under Windows? Also, I think Eruvanos has a mac. Btw, scale changes are actually somewhat conservative. I'm considering more in the future but the current one seemed small enough to merge now. |
This was referenced Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: Non-
#type: ignorefixes for GUI type issues through annotations + int conversionWhy
floatconversion of their labels & layouts, we need to account for it:intbehavior / storage for layoutsfloatstorageChanges
AsFloat = Union[float, inttype to:arcade.gui.Rectarcade.gui.Rect.scalebehaviorrounding=Nonebehavior toarcade.gui.Rect.scale+ testsintconversion shims to stop pyright issues2.1dev*release.pyiuseful to reduce#type: ignorecruftTest steps taken