Clean up draw_commands in areas potentially helpful for #2065#2069
Merged
eruvanos merged 9 commits intopythonarcade:developmentfrom Apr 23, 2024
Merged
Conversation
* Move validation & unpacking ctx members to locals to top of functions * Use Color's from_iterable + normalize * Use named variables for goal buffer sizes to make buffer expansion clearer * Add comments and attempt to make math more readable
* Copy to ctypes array earlier * Skip tuple conversion for array.array since it takes generators
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
TL;DR: Try to improve readability ahead of camera refactor research & prototyping
Why?
TL;DR: Help @DragonMoffon & @DigiDuncan when working on cameras
Vec*issues much sooner than expected__eq__checkpyglet==2.1dev3releaseWhere?
TL;DR: Function bodies where things help draw rects or might use quads
In
draw_commands.py, wherever things look like:draw_polygon_outline)How?
TL;DR: Make the code understandable before even attempting to fix how fast it runs
Color's:from_iterableclassmethodnormalizedpropertyColor.from_iterable(color)validationarray.arraystuplein (array.array('B', tuple(generator))*unpacking positional point arguments instead of indexing