feat: Enable to read for the Q4 coverage and the IQTI files for the fci l1c data

[ClementLaplace]

• Add support for RSS imagery (Q4 coverage)
• test support for RSS imagery (Q4 coverage)
• Add support for IQTI files
• Test for IQTI files

[ameraner]

Hi Clement, thanks for this! Below the first comments.

Another thing: I believe we can get rid of these lines as well

satpy/satpy/readers/fci_l1c_nc.py

Lines 500 to 508 in 9070f29

	# TODO remove this check when old versions of IDPF test data (<v4) are deprecated.
	if coord == "x" and coord_radian.attrs["scale_factor"] > 0:
	coord_radian.attrs["scale_factor"] *= -1
	# TODO remove this check when old versions of IDPF test data (<v5) are deprecated.
	if type(coord_radian.attrs["scale_factor"]) is np.float32:
	coord_radian.attrs["scale_factor"] = coord_radian.attrs["scale_factor"].astype("float64")
	if type(coord_radian.attrs["add_offset"]) is np.float32:
	coord_radian.attrs["add_offset"] = coord_radian.attrs["add_offset"].astype("float64")

With that, please kindly also cleanup the according tests and fixtures for the test class `TestFCIL1cNCReaderBadDataFromIDPF´ that is not needed anymore.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.97%. Comparing base (2bd607a) to head (a5c5022).
Report is 545 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2843      +/-   ##
==========================================
+ Coverage   95.78%   95.97%   +0.18%     
==========================================
  Files         366      368       +2     
  Lines       53521    53973     +452     
==========================================
+ Hits        51267    51801     +534     
+ Misses       2254     2172      -82     

Flag	Coverage Δ
behaviourtests	4.02% <0.00%> (-0.03%)	⬇️
unittests	96.07% <100.00%> (+0.18%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coveralls]

Pull Request Test Coverage Report for Build 10112077539

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 129 of 129 (100.0%) changed or added relevant lines in 2 files are covered.
• 137 unchanged lines in 10 files lost coverage.
• Overall coverage increased (+0.03%) to 96.073%

---

Files with Coverage Reduction	New Missed Lines	%
satpy/tests/reader_tests/gms/test_gms5_vissr_navigation.py	1	97.18%
satpy/enhancements/init.py	1	99.07%
satpy/tests/enhancement_tests/test_enhancements.py	2	99.44%
satpy/readers/hrit_jma.py	2	98.64%
satpy/tests/reader_tests/test_ami_l1b.py	3	98.17%
satpy/readers/ami_l1b.py	4	97.32%
satpy/tests/utils.py	10	93.16%
satpy/readers/olci_nc.py	13	94.4%
satpy/resample.py	49	88.74%
satpy/writers/awips_tiled.py	52	83.97%

Totals
Change from base Build 9702977764:	0.03%
Covered Lines:	52030
Relevant Lines:	54157

---

💛 - Coveralls

[ameraner]

Thanks for the updates. However, I think some tests and modifications are still missing, please check the inline comments.

[ameraner]

Thank you for the revisions, looks good! Just a couple of comments and a new small request on the sun_earth_distance calculation.

[ameraner]

Thanks again! Looks good, some minor comments plus a CodeScene issue to address.

Please also update the documentation parts in the .yaml and the python docstring, specifying that we now support RSS scanning mode as well, and data from both IDPF-I and IQT-I processing facilities.

[ameraner]

Thank you very much for all the work Clement! LGTM, just two minor docstring fixes I just committed.

[mraspaud]

Just a couple of comments/suggestions, but looks good overall!

[mraspaud]

LGTM!