Fix data promotion in generic_image reader and satpy.composites.add_bands #2923
Merged
mraspaud merged 5 commits intopytroll:mainfrom Oct 14, 2024
Merged
Fix data promotion in generic_image reader and satpy.composites.add_bands #2923mraspaud merged 5 commits intopytroll:mainfrom
generic_image reader and satpy.composites.add_bands #2923mraspaud merged 5 commits intopytroll:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2923 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 373 373
Lines 54479 54491 +12
=======================================
+ Hits 52338 52352 +14
+ Misses 2141 2139 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 11323677685Details
💛 - Coveralls |
This was referenced Oct 11, 2024
mraspaud
approved these changes
Oct 14, 2024
Member
mraspaud
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot for refactoring the tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While figuring out why
geo_colorwasfloat64, I found that bothgeneric_imagereader (used to read background images) andsatpy.composites.add_bands()were mishandling the data. This fixes these two bugs in one go, as they both are triggered byBackgroundCompositorfor certain cases.Requires also pytroll/trollimage#186 for the
geo_colorto be fully fixed, theinvertenhancement promotes data tofloat64when the inversion parameters are given for each channel.The
generic_imagereader tests were converted topytest.AUTHORS.mdif not there already