Move fci platform name translate to fci base#3132
Merged
pnuu merged 6 commits intopytroll:mainfrom May 16, 2025
Merged
Conversation
TAlonglong
requested review from
ameraner,
djhoese,
gerritholl and
mraspaud
as code owners
Collaborator
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
pnuu
added
component:readers
cleanup
pnuu
approved these changes
May 15, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3132 +/- ##
=======================================
Coverage 96.22% 96.22%
=======================================
Files 398 398
Lines 57350 57362 +12
=======================================
+ Hits 55185 55197 +12
Misses 2165 2165
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
I restarted the tests, there seemed to be a network glitch or something. |
Pull Request Test Coverage Report for Build 15041525145Details
💛 - Coveralls |
Member
|
I fixed a conflict (one blank line...). Merging after the tests have completed. |
Member
|
pre-commit.ci autofix |
Member
|
I'll check what went wrong with the merge from |
pnuu
approved these changes
May 16, 2025
github-project-automation
bot
moved this from Ready for review
to Done
in PCW Spring 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To harmonise the platform name translate over l1c and l2 readers, move the platform name translate to the fci base file.
AUTHORS.mdif not there already