Skip to content

Add surface type and terrain elevation to the AWS L1b loading#3169

Merged
adybbroe merged 4 commits intopytroll:mainfrom
adybbroe:extend-aws-l1b-reader-with-ancillary-data-loading
Jul 25, 2025
Merged

Add surface type and terrain elevation to the AWS L1b loading#3169
adybbroe merged 4 commits intopytroll:mainfrom
adybbroe:extend-aws-l1b-reader-with-ancillary-data-loading

Conversation

@adybbroe
Copy link
Contributor

This PR adds surface type and terrain elevation to the Arctic Weather Satellite (AWS) L1b loading.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
@adybbroe adybbroe self-assigned this Jul 17, 2025
@adybbroe adybbroe added enhancement code enhancements, features, improvements component:readers labels Jul 17, 2025
@adybbroe adybbroe requested review from TAlonglong and pnuu July 17, 2025 11:42
@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.27%. Comparing base (38d7138) to head (d125b53).
⚠️ Report is 271 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3169      +/-   ##
==========================================
- Coverage   96.28%   96.27%   -0.01%     
==========================================
  Files         436      436              
  Lines       57830    57924      +94     
==========================================
+ Hits        55681    55768      +87     
- Misses       2149     2156       +7     
Flag Coverage Δ
behaviourtests 3.77% <0.00%> (-0.01%) ⬇️
unittests 96.36% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…evel-1c product

Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One small question for a possible change, but fine with me as is.

@djhoese
Copy link
Member

djhoese commented Jul 20, 2025

@adybbroe what's up with these failing tests:

FAILED satpy/tests/reader_tests/test_aws1_mwr_l1c.py::test_get_viewing_geometry_data[solar_azimuth_angle-data/navigation/aws_solar_azimuth_angle-fake_array0] - NotImplementedError: Dataset solar_azimuth_angle not available or not supported yet!
FAILED satpy/tests/reader_tests/test_aws1_mwr_l1c.py::test_get_viewing_geometry_data[solar_zenith_angle-data/navigation/aws_solar_zenith_angle-fake_array1] - NotImplementedError: Dataset solar_zenith_angle not available or not supported yet!
FAILED satpy/tests/reader_tests/test_aws1_mwr_l1c.py::test_get_viewing_geometry_data[satellite_azimuth_angle-data/navigation/aws_satellite_azimuth_angle-fake_array2] - NotImplementedError: Dataset satellite_azimuth_angle not available or not supported yet!
FAILED satpy/tests/reader_tests/test_aws1_mwr_l1c.py::test_get_viewing_geometry_data[satellite_zenith_angle-data/navigation/aws_satellite_zenith_angle-fake_array3] - NotImplementedError: Dataset satellite_zenith_angle not available or not supported yet!

Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
@adybbroe
Copy link
Contributor Author

@adybbroe what's up with these failing tests:

FAILED satpy/tests/reader_tests/test_aws1_mwr_l1c.py::test_get_viewing_geometry_data[solar_azimuth_angle-data/navigation/aws_solar_azimuth_angle-fake_array0] - NotImplementedError: Dataset solar_azimuth_angle not available or not supported yet!
FAILED satpy/tests/reader_tests/test_aws1_mwr_l1c.py::test_get_viewing_geometry_data[solar_zenith_angle-data/navigation/aws_solar_zenith_angle-fake_array1] - NotImplementedError: Dataset solar_zenith_angle not available or not supported yet!
FAILED satpy/tests/reader_tests/test_aws1_mwr_l1c.py::test_get_viewing_geometry_data[satellite_azimuth_angle-data/navigation/aws_satellite_azimuth_angle-fake_array2] - NotImplementedError: Dataset satellite_azimuth_angle not available or not supported yet!
FAILED satpy/tests/reader_tests/test_aws1_mwr_l1c.py::test_get_viewing_geometry_data[satellite_zenith_angle-data/navigation/aws_satellite_zenith_angle-fake_array3] - NotImplementedError: Dataset satellite_zenith_angle not available or not supported yet!

Yes, my bad. Was a bit too fast there. Should be okay now...

@coveralls
Copy link

coveralls commented Jul 24, 2025

Pull Request Test Coverage Report for Build 16527840917

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 32 of 32 (100.0%) changed or added relevant lines in 3 files are covered.
  • 28 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.006%) to 96.381%

Files with Coverage Reduction New Missed Lines %
satpy/tests/utils.py 2 93.19%
satpy/tests/reader_tests/gms/test_gms5_vissr_l1b.py 3 98.67%
satpy/tests/reader_tests/gms/test_gms5_vissr_navigation.py 3 97.18%
satpy/composites/viirs.py 20 94.72%
Totals Coverage Status
Change from base Build 16275716766: -0.006%
Covered Lines: 56063
Relevant Lines: 58168

💛 - Coveralls

Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
@adybbroe adybbroe merged commit 8528a3f into pytroll:main Jul 25, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:readers enhancement code enhancements, features, improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants