Add possibility to override area_def in gerb reader#3220
Add possibility to override area_def in gerb reader#3220djhoese merged 3 commits intopytroll:mainfrom
Conversation
This is necessary because some GERB files do not have the sub-satellite longitude as a parameter.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3220 +/- ##
=======================================
Coverage 96.32% 96.33%
=======================================
Files 463 463
Lines 58181 58189 +8
=======================================
+ Hits 56041 56054 +13
+ Misses 2140 2135 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hello, the Python 3.11 test on windows seems unrelated to this PR, should I restart the tests? |
Does this mean this workaround will no longer be needed in the next release of the GERB L2 software? |
Pull Request Test Coverage Report for Build 17442455296Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
For the next official release of GERB data. Currently, we have the "Edition 1" release where only "GERB files" (so not the GERB like files that lack the attribute) are present, but also the near real time and some (one released dataset called V100) datasets containing GERB + GERB-like but those latter files are unreadable currently. |
|
But indeed at the next release I would like to have this issue resolved within the HDF5 files of GERB and GERB-like directly. |
|
I guess what I'm leading to is should the changes made here just stay in your local copy of Satpy for reading these files? Or should this PR be merged to make it more available to others and/or easier to install in your systems? |
|
I made the PR because one scientist at a partner institution had trouble with those "GERB-like" files. I would like to have it merged :-) |
|
Both suggestions implemented. |
|
🥳 thanks |
This is necessary because some GERB files do not have the sub-satellite longitude as a parameter.
The proposed fix is to add a
reader_kwargsfor the area definition of the gerb reader. The possibilities for overriding aremsg_seviri_fes_9kmormsg_seviri_iodc_9km. Altough unreleased, some data might use IODC at 41.5 degrees instead of 45.5 degrees (see https://usc.tools.eumetsat.int/reports//missions/geo_ssp_iodc.html for the history of sub-satellite points) but I'll have the required attribute added to GERB L2 data for upcoming releases.