fix: onVirtualScroll should be triggered when scrollWidth changed#265
Merged
zombieJ merged 1 commit intoreact-component:masterfrom May 10, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
linxianxi
force-pushed
the
fix-scrollWidth-trigger-onVirtualScroll
branch
from
23c3c38 to
78b8cf2
Compare
linxianxi
changed the title
linxianxi
force-pushed
the
fix-scrollWidth-trigger-onVirtualScroll
branch
from
78b8cf2 to
ae0be6c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #265 +/- ##
==========================================
+ Coverage 98.24% 98.39% +0.15%
==========================================
Files 18 18
Lines 684 686 +2
Branches 163 163
==========================================
+ Hits 672 675 +3
+ Misses 12 11 -1 ☔ View full report in Codecov by Sentry. |
zombieJ
approved these changes
May 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scrollWidth 发生改变，onVirtualScroll 应该触发，这样能得到最新的正确的偏移值