Skip to content

Minor test improvements to support upcoming PHP 8#168

Merged
jsor merged 1 commit intoreactphp:masterfrom
clue-labs:php8
Sep 6, 2020
Merged

Minor test improvements to support upcoming PHP 8#168
jsor merged 1 commit intoreactphp:masterfrom
clue-labs:php8

Conversation

@clue
Copy link
Member

@clue clue commented Sep 5, 2020

This component now supports PHP 8 just fine 🎉

~/workspace/reactphp-dns$ $ docker run -it --rm --net host -v `pwd`:/data --workdir /data php:8.0.0beta2-cli-alpine php vendor/bin/phpunit
PHPUnit 9.3.8 by Sebastian Bergmann and contributors.

...............................................................  63 / 253 ( 24%)
............................................................... 126 / 253 ( 49%)
............................................................... 189 / 253 ( 74%)
............................................................... 252 / 253 ( 99%)
.                                                               253 / 253 (100%)

Time: 00:01.558, Memory: 21.14 MB

OK (253 tests, 675 assertions)

This PR does not currently include PHP 8 in the Travis test matrix. PHP is scheduled to be released in November, I'll file a follow-up PR once it's available for installation on Travis.

Builds on top of #166, #165 and #163

@clue clue added this to the v1.4.0 milestone Sep 5, 2020
@clue clue requested review from WyriHaximus and jsor September 5, 2020 11:14
@jsor jsor merged commit 35f5c2b into reactphp:master Sep 6, 2020
@clue clue deleted the php8 branch September 6, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants