Centralize configuration defaults#642
Merged
peterzhu2118 merged 7 commits intoruby:masterfrom Jul 1, 2022
Merged
Conversation
5929e10 to
3f72e9e
Compare
3f72e9e to
a9ecc1a
Compare
Member
Author
peterzhu2118
reviewed
Jul 1, 2022
a9ecc1a to
20a7f30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we use
CONFIG[:key] || defaultto apply default values at the places we use the config. This has 2 problems:So in this PR, I moved all configs' default to the
config.rb, just right after the config type info. And now the default is synced betweenREADME <-> config command <-> actual logic.Changes on the
configcommand outputBefore
After