Make tests Exception#inspect independent#652
Merged
ko1 merged 3 commits intoruby:masterfrom Jul 5, 2022
Merged
Conversation
st0012
changed the title
Exception#inspect independentException#inspect independent
st0012
commented
Jun 9, 2022
| type "catch Exception" | ||
| type "c" | ||
| type "_raised" | ||
| assert_line_text(/#<NameError: undefined local variable or method `foo' for main:Object/) |
Member
Author
There was a problem hiding this comment.
Note that the exception here is printed with #inspect because that's how debugger prints objects from console (pp + width limit). So it's not produced by the test framework.
Member
Author
|
cc @mame |
st0012
force-pushed
the
improve-test-framework-error-handling
branch
2 times, most recently
from
2a72724 to
c870d26
Compare
Main reason: if ruby/ruby#4857 is implemented, using `#inspect` will lose the newlines from the formatted message. Another reason: test frameworks usually fetch exceptions' class name and message separately to compose the full message, instead of just calling `#inspect`. So our test framework should be implemented similarly.
This will avoid tests from failing because of format changes like ruby/ruby#4857
st0012
force-pushed
the
improve-test-framework-error-handling
branch
from
c870d26 to
3896db0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So the tests won't fail because of changes like ruby/ruby#4857