🐛 Support displaying variables with non-unicode data#758
Merged
ko1 merged 3 commits intoruby:masterfrom Oct 25, 2022
marianosimone:marianosimone/fix_756
Merged
🐛 Support displaying variables with non-unicode data#758ko1 merged 3 commits intoruby:masterfrom marianosimone:marianosimone/fix_756
ko1 merged 3 commits intoruby:masterfrom
marianosimone:marianosimone/fix_756
Conversation
marianosimone
commented
Sep 23, 2022
| }, | ||
| { | ||
| name: "with_binary_data", | ||
| value: "[Invalid encoding] \b�\u0001", |
Contributor
Author
There was a problem hiding this comment.
This is the interesting part! Without the fix, this would have crashed instead
Collaborator
|
Let me check another debuggers on VSCode (DAP servers) |
ko1
reviewed
Oct 24, 2022
Co-authored-by: Koichi Sasada <ko1@atdot.net>
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes #756
DAP is JSON-based, so the state of all variables is dumped into a string that needs to be unicode. When a variable contains binary data that is NOT unicode, this breaks with:
source sequence is illegal/malformed utf-8.This patch makes sure that we can display at least part, and show the user that the data they are seeing is not exactly the one that is in memory.
Testing
I tried this in VSCode (which uses DAP), and saw:
As a side note,
vscode-ruby-debugdoesn't even try to show the variable content and just shows[Invalid encoding], which, IMO, is a worse UX.