Merged
Conversation
Rather than repeating the whole logic for skip_slow, let's rely on the matrix being set.
**What does this PR do?:** This PR takes the build reuse support added in ruby#14 and makes it trigger automatically for 3.4-asan builds. Specifically, since 3.4-asan builds are done from release tags (e.g. v3_4_2), and releases are far and far between, we can reuse a build instead of redoing it. **Motivation:** Reduce CI work. **Additional Notes:** There's a bit of a complexity trade-off here: we need to add a bit more branching logic. **How to test the change?** I've tested the three code paths: * Previous build can be reused => https://github.com/DataDog/ruby-dev-builder/actions/runs/13411682947/job/37463131435 * Previous built **can't** be reused => https://github.com/DataDog/ruby-dev-builder/actions/runs/13411767953/job/37463387098 * skip_slow was set => https://github.com/DataDog/ruby-dev-builder/actions/runs/13411781030/job/37463429665
eregon
reviewed
Mar 4, 2025
| // Entry in body may not exist, but if it doesn't the should_build_3_4_asan is still correct | ||
| const latestRelease34ASanCommit = ((release.body.split('\n')[1] ?? "").split('@')[1] ?? "").trim() | ||
| console.log(`Latest release commit: ${latestReleaseCommit}`) | ||
| console.log(`Latest 3.4-asan release commit: ${latestRelease34ASanCommit}`) |
Member
There was a problem hiding this comment.
Can you move this next to Latest 3.4-asan: so it's easier to compare, example from your build: https://github.com/DataDog/ruby-dev-builder/actions/runs/13411682947/job/37463108782#step:5:25
Could even align all 4 commits vertically to make it even easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This PR takes the build reuse support added in #14 and makes it trigger automatically for 3.4-asan builds.
Specifically, since 3.4-asan builds are done from release tags (e.g. v3_4_2), and releases are far and far between, we can reuse a build instead of redoing it.
Motivation:
Reduce CI work.
Additional Notes:
There's a bit of a complexity trade-off here: we need to add a bit more branching logic.
How to test the change?
I've tested the three code paths: