Fix superclass constant resolution to avoid self-reference#373
Open
pvcresin wants to merge 1 commit intoruby:masterfrom
Open
Fix superclass constant resolution to avoid self-reference#373pvcresin wants to merge 1 commit intoruby:masterfrom
pvcresin wants to merge 1 commit intoruby:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes superclass constant resolution for nested
class Foo < Fooso the resolver no longer picks the class currently being defined.It introduces an exclusion cpath on
StaticReadand applies it fromClassNode#define0before re-resolving the superclass read.A regression scenario was also added at
scenario/regressions/superclass-self-reference.rb.With this case, TypeProf now consistently infers
def call: -> Integerinstead of falling back tountyped.