chore: Remove usage of errors.Cause#5291
Merged
lukemassa merged 1 commit intorunatlantis:mainfrom Feb 2, 2025
Merged
Conversation
lukemassa
requested review from
X-Guardian,
jamengual and
nitrocode
and removed request for
a team
dosubot
bot
added
the
refactoring
Signed-off-by: Luke Massa <lukefrederickmassa@gmail.com>
lukemassa
force-pushed
the
remove_errors_cause
branch
from
ae83247 to
fa651df
Compare
jamengual
approved these changes
Feb 1, 2025
bub3n
pushed a commit
to bub3n/atlantis
that referenced
this pull request
Feb 3, 2025
Signed-off-by: Luke Massa <lukefrederickmassa@gmail.com> Signed-off-by: Petr Bubenik <petr.bubenik@drmax.eu>
1 task
bub3n
pushed a commit
to bub3n/atlantis
that referenced
this pull request
Feb 4, 2025
Signed-off-by: Luke Massa <lukefrederickmassa@gmail.com> Signed-off-by: Petr Bubenik <petr.bubenik@drmax.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
Remove all usages of
errors.Cause()why
We are replacing
pkg/errorswith the standard libraryerrors(#5269). One method the standard library does not have is Cause(). It does have errors.Is, which is in fact just a thin wrapper around the std library's (https://github.com/pkg/errors/blob/master/go113.go#L16), so even though this package is importing and using pkg/errors, when it is changed to import and use std library, this new line will be a no-op.tests
Ran unit tests.
references