fix: Respect server side config for autodiscover

[lukemassa]

what

Respect server side config for autodiscover

why

This was a bug in the original implementation #5267 pointed out in #5772. We were only respecting AutoDiscover settings when set in the repoCfg (i.e., per repo atlantis.yaml), not in the globalCfg (i.e., server side config).

tests

I added some new unit tests, one of which would fail on main, which demonstrates the issue.

atlantis % git status
On branch main
Your branch is up to date with 'origin/main'.

nothing to commit, working tree clean
atlantis % go test ./server/events -run ^TestBuildProjectCmdCtx_AutoDiscoverRespectsRepoConfig$
ok  	github.com/runatlantis/atlantis/server/events	(cached)
atlantis % git checkout respect_server_side_config_for_autodiscover -- server/events/project_command_builder_internal_test.go
atlantis % go test ./server/events -run ^TestBuildProjectCmdCtx_AutoDiscoverRespectsRepoConfig$ | grep FAIL:                 
--- FAIL: TestBuildProjectCmdCtx_AutoDiscoverRespectsRepoConfig (0.01s)
    --- FAIL: TestBuildProjectCmdCtx_AutoDiscoverRespectsRepoConfig/autodiscover_respects_ignore_paths_in_global_config (0.00s)

references

closes: #5772

[lukemassa]

One thing I'm not 100% sure on here, is that the logic I wrote means that if the repo sets autodiscover to enabled but does not specify ignore paths, but the global does specify ignore paths, we act as if no ignore paths are specified.

Is this correct, or should I be merging more surgically?

[jamengual]

One thing I'm not 100% sure on here, is that the logic I wrote means that if the repo sets autodiscover to enabled but does not specify ignore paths, but the global does specify ignore paths, we act as if no ignore paths are specified.

Is this correct, or should I be merging more surgically?

that will be very confusing.C
Is there a way to just use globalCfg even if repoCfg is specify and only use repoCfg when no globalCfg is specify?

[lukemassa]

Works for me!

[lukemassa]

OK updated to prefer global and only look at repoCfg if global is absent. I also updated the tests and documentation to clarify.

[lukemassa]

To get this to work I had to remove a unit test from project_command_builder_test.go. The issue is it's using the unit test's default globalCfg, which has Repos set and Autoenable set on them, and is hard to override. Since the logic is now "if global has it, ignore repoCfg", we can't test ignore_paths there. However we test it in project_command_builder_internal_test.go so we should be ok