fix: Nil pointer dereference in atlantis version command#5971
Merged
jamengual merged 2 commits intorunatlantis:mainfrom Nov 20, 2025
Merged
fix: Nil pointer dereference in atlantis version command#5971jamengual merged 2 commits intorunatlantis:mainfrom
jamengual merged 2 commits intorunatlantis:mainfrom
Conversation
### What Fix nil pointer panic in VersionStepRunner Initialize DefaultTFDistribution field in VersionStepRunner to match pattern used by InitStepRunner, ApplyStepRunner, and ImportStepRunner. ### Why Without this field, version command panics with nil pointer dereference at terraform_client.go:509 when terraform binary cache is empty (after Atlantis restart, upgrade, or cache clear). ### Tests Reproduction: Clear cache on Atlantis instance (rm -rf ~/.atlantis/bin/*), run `atlantis version` Result: Panic before fix, works correctly after fix. Tested on locally build docker image with a fixed code. ### References Signed-off-by: Adam Gościcki <adamgoscicki@gmail.com>
dosubot
bot
added
bug
bschaatsbergen
previously approved these changes
Nov 20, 2025
Signed-off-by: Adamovix <adamgoscicki@gmail.com>
bschaatsbergen
approved these changes
Nov 20, 2025
Contributor
|
Thanks @Adamovix for the contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
Fixes #5972
Initialize DefaultTFDistribution field in VersionStepRunner to match pattern used by InitStepRunner, ApplyStepRunner, and ImportStepRunner.
why
Without this field,
atlantis versioncommand causes two bugs:Bug 1: Nil pointer panic
dist.BinName()on nil distributionBug 2: Command failure on fresh instances
tests
Reproduction:
rm -rf ~/.atlantis/bin/*atlantis versionResult:
Tested on locally built Docker image with fix applied.
references