Update ndarray to Rust 2018 edition#567
Merged
jturner314 merged 1 commit intorust-ndarray:masterfrom Dec 11, 2018
Merged
Conversation
17 tasks
1c49151 to
eacc789
Compare
bluss
approved these changes
Dec 10, 2018
Member
bluss
left a comment
There was a problem hiding this comment.
I'm very happy with the new path rules so far. Rust 2018 ftw
|
Is there a |
Member
|
Several breaking changes merged and coming, so it's a bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the changes are adding a
crateprefix tousestatements and changingtry!to?. I also renamedlibnumtonum_traitsbecausecargo fixwas wanting to add acrateprefix, e.g.use crate::libnum::Whatever, and I didn't see any reason for thenum-traitscrate to be renamed tolibnumanyway.This PR changes only the
ndarraycrate; it doesn't change thendarray-randcrate.Edit: Also note that I've just run
cargo fix --editionand made some manual improvements. I haven't runcargo fix --edition-idioms, because according to the docs,--edition-idiomsisn't ready yet.