Conversation
Open
razor-x
commented
Nov 13, 2024
Comment on lines
+5
to
+6
| require_relative "routes/resources/index" | ||
| require_relative "routes/clients/index" |
Member
Author
There was a problem hiding this comment.
@andrii-balitskyi This is a work around. We should remove these lines from there and lib/seam/http_multi_workspace.rb and move them into "routes/routes.rb` instead. Can you PR for that later? 🙏🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extra require statements in the spec_helper were giving false positives. The tests would pass but then there would be runtime errors because those require statements were otherwise missing when using the sdk.
These updates should resolve the require dependencies. We can restructure the lib folders a bit to make this more transparent, e.g., put each module in a directory if more than one file externs the module, e.g.,
lib/seam/http/auth.rb,lib/seam/http/options.rbetc.