Avoid z_score numeric exception for conversion rates >1#503
Merged
andrew merged 1 commit intosplitrb:masterfrom Sep 20, 2017
Merged
Avoid z_score numeric exception for conversion rates >1#503andrew merged 1 commit intosplitrb:masterfrom
andrew merged 1 commit intosplitrb:masterfrom
Conversation
At normal operation, it's not possible for an experiment to have a `participant_count` > `completed_count`. However, by manually using `increment_participation` (for a custom use-case or by accident) you can arrive on such a situation. If that happens, `Zscore.calculate` produces an error that propagates all the way up to the web view. Solution: In the cornercase of a conversion rates taking a value >1, it makes no sense to calculate a zscore value at all. An escape clause was added
Member
|
Thanks! |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At normal operation, it's not possible for an experiment alternative
to have a
participant_count>completed_count.However, by manually using
increment_participation(for a custom use-case or by accident) you can arrive
on such a situation.
If that happens,
Zscore.calculateproduces an error thatpropagates all the way up to the web view.
Solution:
In the cornercase of a conversion rates taking a value >1,
it makes no sense to calculate a zscore value at all.
An escape clause was added