Fix cookie header duplication#522
Merged
andrew merged 3 commits intosplitrb:masterfrom May 17, 2018
andrehjr:fix-cookie-header-duplication
Merged
Fix cookie header duplication#522andrew merged 3 commits intosplitrb:masterfrom andrehjr:fix-cookie-header-duplication
andrew merged 3 commits intosplitrb:masterfrom
andrehjr:fix-cookie-header-duplication
Conversation
Otherwise parse current cookies set on response and replace it using Rack directly.
New methods like Rack::Utils#make_delete_cookie_header were only added on 2.0.0
Member
|
Looks good to me, thanks for tackling this 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #508 and fix a bug introduced by #490
Using ActionDispatch::Cookies from rails, manages flushing/replacing cookies on its own. Sinatra also have something like it on Sinatra::Cookies.
When using Rack directly you have to take care of that. Each time set_cookie was called it was adding another Set-Cookie entry to response.
This PR does: