Caching based optimization in the experiment#save path#652
Merged
andrehjr merged 3 commits intosplitrb:masterfrom Dec 13, 2020
Merged
Caching based optimization in the experiment#save path#652andrehjr merged 3 commits intosplitrb:masterfrom
andrehjr merged 3 commits intosplitrb:masterfrom
Conversation
Contributor
Author
|
@andrehjr Hi Andre -- this is another update mainly to gain more performance. We have tested this internally and seems to work correctly for us. |
…nfig to take effect
amangup
changed the title
Contributor
Author
|
cc @rdh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds caching in the experiment save path to use the cached experiment config instead of making redis calls to compare new and existing configs.
Have cache clear in the
Experiment#resetcall which allows runtime update of experiment config without reboot required.Have cache clear in the
Experiment#reset_winnercall which allows runtime update of experiment winner without reboot required.