Conversation
…can lead to negative numbers
andrehjr
force-pushed
the
check-if-alternatives-have-valid-data
branch
from
eba5a64 to
cfd61ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We stumbled on situation at work where we had a completed_count greater than participant_count.
When calculating the probability this can lead to negative numbers which are not valid input for Beta Distribution. So RubyStats throws an error right away.
I still need more info on when/how this happens. But the Dashboard should not blow up in any case because of this. So I'm adding this check.