feat(isPostalCode): support for IR locale#1515
Merged
profnandaa merged 1 commit intovalidatorjs:masterfrom Nov 29, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1515 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 96 96
Lines 1277 1277
=======================================
Hits 1276 1276
Misses 1 1
Continue to review full report at Codecov.
|
farhang
approved these changes
Nov 7, 2020
profnandaa
reviewed
Nov 19, 2020
Member
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
LGTM, please update the README too. Thanks for your contrib! 🎉
profnandaa
added
the
🧹 needs-update
Contributor
Author
@profnandaa IR locale already was existed on REDME.
|
Member
|
oh, got it, thx
On Thu, Nov 19, 2020 at 6:33 PM msdDaliriyan ***@***.***> wrote:
LGTM, please update the README too. Thanks for your contrib! 🎉
@profnandaa <https://github.com/profnandaa> IR locale already was existed
on REDME.
[image: Screen Shot 2020-11-19 at 18 56 37]
<https://user-images.githubusercontent.com/25932831/99686996-65ba4080-2a99-11eb-9758-b882cb2781f2.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1515 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB7ZEKRUHYV52D3ESH2JSTSQU3GHANCNFSM4TJJ3KAA>
.
--
Sent from a tiny device while on the move.
|
Contributor
Author
|
@profnandaa please remove needs-update tag |
profnandaa
removed
the
🧹 needs-update
profnandaa
approved these changes
Nov 29, 2020
Member
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution.
This was referenced Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{{ briefly describe what you have done in this PR }}
Checklist