feat(isEmail): add host_blacklist option#1641
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1641 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 100 100
Lines 1847 1849 +2
=========================================
+ Hits 1847 1849 +2
Continue to review full report at Codecov.
|
tux-tn
left a comment
There was a problem hiding this comment.
A little suggestion, we have a similar option in isURL called host_whitelist and host_blacklist that accepts hosts and regexes. What do you think about matching that behaviour to have consistency between validators options?
|
It makes sense but I would keep the I have nothing against |
Project maintainer views on this matter have already been shared here #1522 |
domain_denylist optionhost_blacklist option
|
It's always a good time to change your mind 🤷♂️ |
6e2b0e1 to
ac4896c
Compare
|
Ping? |
tux-tn
left a comment
There was a problem hiding this comment.
LGTM 🎉
Sorry for the long review delay, i missed the notification about new commits in this PR !
We add an option to allow the user to exclude some specific domains from
isEmailvalidation.Fixes #1639
Checklist