feat(isURL): add allow_fragments and allow_query_components#1721
Merged
profnandaa merged 2 commits intovalidatorjs:masterfrom Sep 26, 2021
cowboy-bebug:el/add-options
Merged
feat(isURL): add allow_fragments and allow_query_components#1721profnandaa merged 2 commits intovalidatorjs:masterfrom cowboy-bebug:el/add-options
allow_fragments and allow_query_components#1721profnandaa merged 2 commits intovalidatorjs:masterfrom
cowboy-bebug:el/add-options
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1721 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 101 101
Lines 2005 2009 +4
Branches 452 454 +2
=========================================
+ Hits 2005 2009 +4
Continue to review full report at Codecov.
|
tux-tn
approved these changes
Sep 6, 2021
Member
tux-tn
left a comment
There was a problem hiding this comment.
Great work @cowboy-bebug and congrats for your first contribution here 👏 !
LGTM 🎉
Contributor
Author
|
Thanks @tux-tn! |
profnandaa
approved these changes
Sep 26, 2021
Member
profnandaa
left a comment
There was a problem hiding this comment.
Thanks for your contrib! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there 👋
Contributing a couple of options for
isURLto make it more flexible:allow_fragmentstrueby defaultfalse, isURL returns false if#is present in urlallow_query_componentstrueby defaultfalse, isURL returns false if?or&is present in urlChecklist