perf(isISO31661Alpha2): use a Set along with .has instead of includes#1724
Merged
profnandaa merged 1 commit intovalidatorjs:masterfrom Sep 20, 2021
Merged
Conversation
fix(isBIC): refactor use of CountryCodes using Set's methods
Codecov Report
@@ Coverage Diff @@
## master #1724 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 101 101
Lines 2005 2005
Branches 452 452
=========================================
Hits 2005 2005
Continue to review full report at Codecov.
|
profnandaa
approved these changes
Sep 20, 2021
Member
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
LGTM too, thanks for your contrib!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
perf(isISO31661Alpha2): use a Set along with .has instead of includes
fix(isBIC): refactor use of CountryCodes using Set's methods
Updated
isISO31661Alpha2to use aSetalong with.hasto reduce complexity from O(n) to O(1) as stated here.Updated
isBICto use Set's methods instead of Array's.Checklist