feat(isUrl): higher priority to whitelist #1748
feat(isUrl): higher priority to whitelist #1748profnandaa merged 2 commits intovalidatorjs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1748 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2015 2029 +14
Branches 454 457 +3
=========================================
+ Hits 2015 2029 +14
Continue to review full report at Codecov.
|
|
@tux-tn please review |
tux-tn
left a comment
There was a problem hiding this comment.
Hello,
Thank you @deepanshu2506 for your PR ! Please address my comment and we should be good to go 👍
Is your contribution related to hacktoberfest ?
package.json
Outdated
| }, | ||
| "license": "MIT" | ||
| } No newline at end of file | ||
| } |
There was a problem hiding this comment.
Can you revert your changes to package.json, i guess your code editor added a new line here !
There was a problem hiding this comment.
i'll make the changes and yes my contribution is related to hacktoberfest
|
yes my contribution related to hacktoberfest |
|
@tux-tn I have addressed the required changes. |
profnandaa
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contrib!
This reverts commit 13651ea. reverted
check the whitelist before checking if URL is a IP or FQDN.
resolves #1731
Checklist