feat(isIdentityCard): Add isIdentityCard 'LK' (Sri Lanka) locale#1786
Merged
profnandaa merged 4 commits intovalidatorjs:masterfrom Oct 30, 2021
Merged
feat(isIdentityCard): Add isIdentityCard 'LK' (Sri Lanka) locale#1786profnandaa merged 4 commits intovalidatorjs:masterfrom
profnandaa merged 4 commits intovalidatorjs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1786 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2029 2035 +6
Branches 457 459 +2
=========================================
+ Hits 2029 2035 +6
Continue to review full report at Codecov.
|
Contributor
Author
|
Hi, I would like to know why "Run tests on Node.js 6" is failing and how to fix that. |
Member
|
@nimanthadilz the issue was related to a broken dependency, it has been fixed and your pipeline passed on Node.js 6 |
tux-tn
requested changes
Oct 25, 2021
Member
tux-tn
left a comment
tux-tn
left a comment
There was a problem hiding this comment.
Thank you for your PR @nimanthadilz ! Mostly LGTM, i added a little comment that need to be adressed.
tux-tn
added
🎉 first-pr
🧹 needs-update
Co-authored-by: Sarhan Aissi <tux-tn@users.noreply.github.com>
Contributor
Author
|
I committed the changes requested. This contribution was done as part of Hacktoberfest. It's a pleasure to contribute to opensource. |
tux-tn
added
hacktoberfest-accepted
ready-to-land
profnandaa
approved these changes
Oct 30, 2021
Member
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
Thanks for your contrib! 🎉
theteladras
pushed a commit
to theteladras/validator.js
that referenced
this pull request
Oct 30, 2021
* Implement isIdentityCard LK(Sri Lanka) locale * Add tests for isIdentityCard LK locale * Update README.md for the isIdentityCard LK locale * Change let to const Co-authored-by: Sarhan Aissi <tux-tn@users.noreply.github.com> Co-authored-by: Sarhan Aissi <tux-tn@users.noreply.github.com>
profnandaa
pushed a commit
that referenced
this pull request
Oct 31, 2021
* Implement isIdentityCard LK(Sri Lanka) locale * Add tests for isIdentityCard LK locale * Update README.md for the isIdentityCard LK locale * Change let to const Co-authored-by: Sarhan Aissi <tux-tn@users.noreply.github.com> Co-authored-by: Sarhan Aissi <tux-tn@users.noreply.github.com>
profnandaa
pushed a commit
that referenced
this pull request
Oct 31, 2021
* Implement isIdentityCard LK(Sri Lanka) locale * Add tests for isIdentityCard LK locale * Update README.md for the isIdentityCard LK locale * Change let to const Co-authored-by: Sarhan Aissi <tux-tn@users.noreply.github.com> Co-authored-by: Sarhan Aissi <tux-tn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added the validation for Sri Lanka's NIC (National Identity Card) in
isIdentityCardvalidator. Both old and new NIC numbers are validated and tests are provided.Checklist