fix: Russian passport number regex#1810
Merged
profnandaa merged 2 commits intovalidatorjs:masterfrom Oct 30, 2021
Theta-Dev:master
Merged
fix: Russian passport number regex#1810profnandaa merged 2 commits intovalidatorjs:masterfrom Theta-Dev:master
profnandaa merged 2 commits intovalidatorjs:masterfrom
Theta-Dev:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1810 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2029 2029
Branches 457 457
=========================================
Hits 2029 2029
Continue to review full report at Codecov.
|
tux-tn
approved these changes
Oct 19, 2021
Member
tux-tn
left a comment
tux-tn
left a comment
There was a problem hiding this comment.
LGTM ! Thank you for your PR @Theta-Dev 🎉
I was going to answer you concerning the white spaces. It looks like you figured out that the validator itself is stripping white-spaces before passing the string to regex and changed your regex 😃
tux-tn
added
🎉 first-pr
ready-to-land
profnandaa
reviewed
Oct 30, 2021
profnandaa
approved these changes
Oct 30, 2021
theteladras
pushed a commit
to theteladras/validator.js
that referenced
this pull request
Oct 30, 2021
* fix: Russian passport number regex fixes validatorjs#1807
profnandaa
pushed a commit
that referenced
this pull request
Oct 31, 2021
* fix: Russian passport number regex fixes #1807
profnandaa
pushed a commit
that referenced
this pull request
Oct 31, 2021
* fix: Russian passport number regex fixes #1807
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1807
updated RU passport number regex to accept 9 digit numbers.