Conversation
Codecov Report
@@ Coverage Diff @@
## master #1989 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 103 103
Lines 2097 2174 +77
Branches 473 475 +2
=========================================
+ Hits 2097 2174 +77
Continue to review full report at Codecov.
|
Member
|
Can you add new tests for these? |
Contributor
Author
|
@WikiRik I added some tests for all element of vat validator list |
Member
|
@Dev1lDragon can you squash the commits. There seems to be more than 10+ commits |
Update isVAT.js Add basic regex support to all countries listed in [VAT identification number - Wikipedia](https://en.wikipedia.org/wiki/VAT_identification_number); More extended validation for PT(Portugal). Update isVAT.js Update isVAT.js Update isVAT.js Update isVAT.js Update isVAT.js Update isVAT.js Update validators.js Update validators.js Update validators.js Update isVAT.js Update isVAT.js Update isVAT.js Update isVAT.js Update isVAT.js Update isVAT.js
tux-tn
previously requested changes
Jun 24, 2022
Member
tux-tn
left a comment
tux-tn
left a comment
There was a problem hiding this comment.
Thank you for your PR @Dev1lDragon, can you please add an entry to the README file to include the added country codes in isVAT ?
tux-tn
added
🧹 needs-update
Add available country codes in isVAT
rubiin
approved these changes
Jul 17, 2022
rubiin
approved these changes
Jul 18, 2022
rubiin
approved these changes
Jul 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add basic regex support to all countries listed in VAT identification number - Wikipedia;
More extended validation for PT(Portugal).
Checklist