Feat: enchance isCreditCard

[brianwhaley]

Add regex validation for AmEx card

[rubiin]

hey there, instead of making a case specific validator, I would suggest something like isDebitcard or isCreditCard followed by provider as a param

[brianwhaley]

hey @rubiin i have refactored the isCreditCard file, will be submitting just submitted a new PR shortly. Thanks for you suggestions!

[codecov]

Codecov Report

Merging #2008 (0eaded6) into master (1bb14e8) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #2008   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2203      2210    +7     
  Branches       477       481    +4     
=========================================
+ Hits          2203      2210    +7     

Impacted Files	Coverage Δ
src/lib/isCreditCard.js	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[rubiin]

Looks good, lets wait for others

[brianwhaley]

Thank you @rubiin. @profnandaa when you have an opportunity please do look at the PR. Much appreciated!

[brianwhaley]

apologies, thought this was approved and started cleaning up too soon. PR is reopened and waiting for approval from @profnandaa

[rubiin]

I found out that we already have isCreditCard. You can enhance it by adding your changes. We might have to consider releasing this on next major release as it would introduce a breaking change

[brianwhaley]

@rubiin - i did modify the existing isCreditCard file, and ensured it was backwards compatible. can you evaluate the diff? you will see you can still pass in a credit card number without the second param, and still get the same result. Thanks

[rubiin]

LGTM

[brianwhaley]

Hi @rubiin and @profnandaa - is there an additional person that can approve this PR? I would like to get it merged to main. Thank you!

[rubiin]

Lets wait for @profnandaa

[brianwhaley]

@profnandaa and @rubiin , is there an additional person that can approve this PR? I would like to get it merged to main. Thank you!

[brianwhaley]

@WikiRik would you be able to review this PR ? Thank you!

[WikiRik]

@brianwhaley I can, but my review won't get this merged faster unfortunately. We'll have to wait for @profnandaa

Either way you can still use this specific commit in other projects, see this NPM docs