feat(isAlpha, isAlphanumeric): add Japanese locale(ja-JP)#2014
Merged
profnandaa merged 1 commit intovalidatorjs:masterfrom Oct 17, 2022
Merged
feat(isAlpha, isAlphanumeric): add Japanese locale(ja-JP)#2014profnandaa merged 1 commit intovalidatorjs:masterfrom
profnandaa merged 1 commit intovalidatorjs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2014 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 104 104
Lines 2203 2203
Branches 477 477
=========================================
Hits 2203 2203
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rubiin
approved these changes
Aug 4, 2022
rubiin
added
ready-to-land
profnandaa
approved these changes
Oct 17, 2022
Member
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contrib! 🎉 I'd never noticed that we didn't have ja-JP locale for isAlpha/numeric.
|
Hey guys, I'm wondering when that will be published as a next release version?
|
This was referenced Jun 3, 2024
This was referenced Jun 12, 2024
This was referenced Jun 14, 2024
This was referenced Jun 20, 2024
This was referenced Jul 10, 2024
This was referenced Jul 19, 2024
This was referenced Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I added Japanese locale(ja-JP) to isAlpha/isAlphanumeric.
Please review my PR!!
Thanks in advance.
Checklist