fix(isBIC): add XK to accepted BIC country codes#2046
fix(isBIC): add XK to accepted BIC country codes#2046profnandaa merged 7 commits intovalidatorjs:masterfrom
XK to accepted BIC country codes#2046Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2046 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 105 105
Lines 2334 2335 +1
Branches 586 586
=========================================
+ Hits 2334 2335 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ST-DDT
left a comment
There was a problem hiding this comment.
Maybe extract the country code to its own variable instead of resolving it twice?
|
Would it be better to add the country code to the Set of country codes in isISO21661Alpha2.js? |
|
No, it's not part of that list. It's a special code used only for BIC (in the scope of this project) |
WikiRik
left a comment
There was a problem hiding this comment.
Could you add some tests for the XK BIC? Preferably some valid and invalid.
You can add them to the current test;
validator.js/test/validators.test.js
Lines 5070 to 5088 in 753c29d
profnandaa
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contrib 🎉
Adds the country code
XK(Republic of Kosovo) toisBIC's allowed country codescloses #2045
Checklist