feat(isAfter): allow usage of options object#2075
feat(isAfter): allow usage of options object#2075profnandaa merged 6 commits intovalidatorjs:masterfrom WikiRik:WikiRik/isAfter-options-refactor
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2075 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 105 105
Lines 2335 2334 -1
Branches 586 586
=========================================
- Hits 2335 2334 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Looks like a nice addition IMO. Since this is a common use case, Lets add it |
|
Not sure how I removed the review requests of the maintainers, but obviously I still want them. Just wanted to re-request it from @braaar |
|
I think camelCase is the preferred naming convention for files – I let my kebab-case habits affect my suggestion 😅 |
|
@pixelbucket-dev had a good point here which I will incorporate in this PR as well. |
rubiin
left a comment
There was a problem hiding this comment.
Nice work on the file renames as well. Meant to do it sooner or later
Is it though? I think that pattern was introduced by React, but in JS world, before React, kebap-case was the default for file names. Especially since code should work on different file system, which are not case-sensitive. You can check: https://google.github.io/styleguide/jsguide.html In the end, this topic is quite opinionated 😄, but keeping things backwards-compatible should dictate lower-case file names. However, the most important rule should be consistency :). |
This PR implements steps 1 and 2 of #1874 for
isAfter. It also has a commit to allow for splitting tests to different files which can be made into a separate PR if requested, this part is inspired by #1793.For the change in the README I've chosen for something comparable to
containswhich I quite liked. This format would be used for the other refactors as well, so feel free to comment with other suggestions.Checklist