refactor(isBtcAddress): get rid of unnecessary if statement and comment#2132
Merged
profnandaa merged 1 commit intovalidatorjs:masterfrom Jan 22, 2023
Merged
Conversation
* there is no need to do a check before, which RegExp use * refactored version also is bit faster as well, according to Benchmark.js tests I did
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2132 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 104 104
Lines 2308 2306 -2
Branches 578 578
=========================================
- Hits 2308 2306 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
WikiRik
approved these changes
Dec 19, 2022
rubiin
approved these changes
Jan 21, 2023
This was referenced Jun 3, 2024
This was referenced Jun 12, 2024
This was referenced Jun 14, 2024
This was referenced Jun 20, 2024
This was referenced Jul 10, 2024
This was referenced Jul 19, 2024
This was referenced Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
[ ] README updated (where applicable)[ ] Tests written (where applicable)