test(validators): remove duplicated test block from isMobilePhone#2137
Merged
profnandaa merged 1 commit intovalidatorjs:masterfrom Jan 22, 2023
Merged
Conversation
not sure what happened there, when this was committed with 2e6cc37 The test here is just a "merged" test of the individual en-ZA and be-BY tests. The individual tests themselves for en-ZA and be-BY are also still there and valid.
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2137 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 104 104
Lines 2308 2308
Branches 578 578
=========================================
Hits 2308 2308 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
WikiRik
approved these changes
Dec 20, 2022
rubiin
approved these changes
Jan 21, 2023
rubiin
added
ready-to-land
This was referenced Jun 3, 2024
This was referenced Jun 12, 2024
This was referenced Jun 20, 2024
This was referenced Jul 10, 2024
This was referenced Jul 19, 2024
This was referenced Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The removed test block here is just a "merged" test of the individual en-ZA and be-BY tests for isMobilePhone.
The individual tests themselves for en-ZA and be-BY are also still there and valid and remain untouched by this PR.
Not really sure what exactly happened there, when this was committed with 2e6cc37, all I know is, that we should remove it
Checklist
[ ] README updated (where applicable)[ ] Tests written (where applicable)