feat(ulid): ULID validation#2294
Merged
profnandaa merged 3 commits intovalidatorjs:masterfrom Jun 23, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2294 +/- ##
===========================================
- Coverage 100.00% 99.95% -0.05%
===========================================
Files 110 108 -2
Lines 2510 2455 -55
Branches 633 620 -13
===========================================
- Hits 2510 2454 -56
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. |
3 tasks
rubiin
previously approved these changes
May 10, 2024
profnandaa
added
the
mc-to-land
profnandaa
reviewed
Jun 22, 2024
Member
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
LGTM, pls fix the merge conflict and we should be good to go.
Contributor
Author
|
@profnandaa |
rubiin
previously approved these changes
Jun 22, 2024
rubiin
approved these changes
Jun 23, 2024
rubiin
removed
the
mc-to-land
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added validation for ULID (Universally Unique Lexicographically Sortable Identifier).
Read more details on ULID in github:ulid/spec
ULID Generator and validations on https://ulid.page
Checklist