feat(isUUID): support uuid v7#2345
Merged
profnandaa merged 1 commit intovalidatorjs:masterfrom Apr 25, 2024
ruscon:patch-1
Merged
feat(isUUID): support uuid v7#2345profnandaa merged 1 commit intovalidatorjs:masterfrom ruscon:patch-1
profnandaa merged 1 commit intovalidatorjs:masterfrom
ruscon:patch-1
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2345 +/- ##
==========================================
- Coverage 99.95% 99.95% -0.01%
==========================================
Files 107 107
Lines 2454 2449 -5
Branches 619 619
==========================================
- Hits 2453 2448 -5
Partials 1 1 ☔ View full report in Codecov by Sentry. |
WikiRik
requested changes
Dec 11, 2023
Member
WikiRik
left a comment
WikiRik
left a comment
There was a problem hiding this comment.
Format looks good, please add some tests in https://github.com/validatorjs/validator.js/blob/master/test/validators.test.js
You can ignore the failure of codecov/project. That is not due to your changes
Contributor
Author
|
@WikiRik Done, waiting for you. |
somarjun
approved these changes
Dec 15, 2023
rubiin
approved these changes
Dec 27, 2023
devlopersabbir
approved these changes
Jan 4, 2024
profnandaa
approved these changes
Apr 25, 2024
Member
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
LGTM.
And sorry for the delayed response. Will go into the next release.
This was referenced Sep 20, 2024
This was referenced Sep 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2344
Checklist