feat(isMobilePhone): update phone regex for Ghana en-GH #2362
Merged
rubiin merged 4 commits intovalidatorjs:masterfrom Nov 12, 2024
Merged
feat(isMobilePhone): update phone regex for Ghana en-GH #2362rubiin merged 4 commits intovalidatorjs:masterfrom
rubiin merged 4 commits intovalidatorjs:masterfrom
Conversation
ezkemboi
previously requested changes
Jan 28, 2024
Member
ezkemboi
left a comment
ezkemboi
left a comment
There was a problem hiding this comment.
left comment, please add tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2362 +/- ##
==========================================
- Coverage 99.95% 99.95% -0.01%
==========================================
Files 107 107
Lines 2454 2449 -5
Branches 619 619
==========================================
- Hits 2453 2448 -5
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
test added for 53 |
WikiRik
approved these changes
May 7, 2024
rubiin
approved these changes
Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added phoneNumber regex for MTN Ghana phone numbers tarting with 53
Checklist