ci: add latest node versions#2364
Merged
profnandaa merged 5 commits intovalidatorjs:masterfrom Apr 25, 2024
rubiin:master
Merged
ci: add latest node versions#2364profnandaa merged 5 commits intovalidatorjs:masterfrom rubiin:master
profnandaa merged 5 commits intovalidatorjs:masterfrom
rubiin:master
Conversation
WikiRik
reviewed
Jan 27, 2024
Member
WikiRik
left a comment
WikiRik
left a comment
There was a problem hiding this comment.
Updating line 23 to npm install --legacy-peer-deps should fix the failing CI
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2364 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 107 107
Lines 2449 2449
Branches 619 619
=========================================
Hits 2449 2449 ☔ View full report in Codecov by Sentry. |
WikiRik
approved these changes
Jan 27, 2024
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
WikiRik
requested changes
Jan 28, 2024
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
ezkemboi
reviewed
Jan 28, 2024
Member
ezkemboi
left a comment
ezkemboi
left a comment
There was a problem hiding this comment.
It seems, reduced tests.
Also, we will need to do more testing on the latest versions
WikiRik
approved these changes
Mar 27, 2024
Member
Author
|
@profnandaa this too |
profnandaa
approved these changes
Apr 25, 2024
This was referenced Sep 20, 2024
This was referenced Sep 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist