feat(isPostalCode): add BD locale#2551
Merged
rubiin merged 4 commits intovalidatorjs:masterfrom May 13, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2551 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2535 2535
Branches 641 641
=========================================
Hits 2535 2535 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WikiRik
previously approved these changes
Apr 9, 2025
Member
WikiRik
left a comment
There was a problem hiding this comment.
Looks good! Just a small suggestion to simplify the regex
WikiRik
approved these changes
Apr 10, 2025
Contributor
Author
|
Any update on this one? |
rubiin
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
README.mddocumentation, theisPostalCodevalidation logic, and the associated tests to add support for Bangladeshi postal codes.Documentation update:
README.md: Added 'BD' (Bangladesh) to the list of supported locales for theisPostalCodefunction.Validation logic update:
src/lib/isPostalCode.js: Added a new regular expression pattern for Bangladeshi postal codes to thepatternsobject.Test update:
test/validators.test.js: Added test cases for Bangladeshi postal codes, including both valid and invalid examples.Reference: Bangladehi postal code list in Wikipedia
Checklist