fix(isBase64): simplify padding RegExp to prevent stack overflow#2574
fix(isBase64): simplify padding RegExp to prevent stack overflow#2574rubiin merged 2 commits intovalidatorjs:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2574 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2535 2536 +1
Branches 641 642 +1
=========================================
+ Hits 2535 2536 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Who is able to provide additional approvals and get this published? We've got production issues as a result of this. Need to decide whether we downgrade or hold out. |
|
Also here with same issue on production. Currently using in nestjs class-validator library, which depends on this library. This a big problem for some partners, which send large documents. Here is an example: |
|
@rubiin are you able to review this soon? After merging this I want to get another release out |
|
Thanks for your effort resolving this issue. Hope it gets released soon 🙏 |
Solves #2491 and #2573
Separate length check and then simplify regex to match any number of valid characters and 0 to 2 = on the end. Length check will ensure the {4} grouping is no longer necessary.
Checklist