fix: URL validation for hostnames with ports (no protocol)#2622
Merged
rubiin merged 1 commit intovalidatorjs:masterfrom Nov 4, 2025
Merged
fix: URL validation for hostnames with ports (no protocol)#2622rubiin merged 1 commit intovalidatorjs:masterfrom
rubiin merged 1 commit intovalidatorjs:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2622 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2562 2566 +4
Branches 649 651 +2
=========================================
+ Hits 2562 2566 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WikiRik
approved these changes
Nov 3, 2025
1 task
rubiin
approved these changes
Nov 4, 2025
benoitf
added a commit
to benoitf/desktop
that referenced
this pull request
Nov 10, 2025
fixes regression at validatorjs/validator.js#2622 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
added a commit
to benoitf/desktop
that referenced
this pull request
Nov 10, 2025
fixes regression at validatorjs/validator.js#2622 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
1 task
benoitf
added a commit
to podman-desktop/podman-desktop
that referenced
this pull request
Nov 10, 2025
fixes regression at validatorjs/validator.js#2622 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in
isURLwhere URLs likelocalhost:3000andservice-name:8080were incorrectly rejected whenrequire_protocolwas set tofalse. The validator was misinterpreting the colon inhostname:portpatterns as a protocol delimiter.I added tests to cover this case and a couple other option variations.
Regression #2608
Closes #2620
Checklist