fix(install script)!: exit with non-zero exit code on error#2083
Open
oscar-vitecenova wants to merge 1 commit intovolta-cli:mainfrom
Open
fix(install script)!: exit with non-zero exit code on error#2083oscar-vitecenova wants to merge 1 commit intovolta-cli:mainfrom
oscar-vitecenova wants to merge 1 commit intovolta-cli:mainfrom
Conversation
|
Pull request and add workflows to fix workflow non-implementation issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The install script should exit with a non-zero exit code when an error occurs during the installation. Otherwise users invoking the script can't handle the error on their end. Currently the script exits with zero exit code even when an error occurs.