fix: Drop Python 3.8 from dev resolution and CI test matrix#554
Open
workos-sdk-automation[bot] wants to merge 1 commit intomainfrom
Open
fix: Drop Python 3.8 from dev resolution and CI test matrix#554workos-sdk-automation[bot] wants to merge 1 commit intomainfrom
workos-sdk-automation[bot] wants to merge 1 commit intomainfrom
Conversation
Python 3.8 reached EOL in October 2024. This change: - Adds `environments = ["python_version >= '3.9'"]` to [tool.uv] so the lockfile only resolves for Python 3.9+, unblocking Renovate PRs that bump dev deps (pytest, mypy, pytest-asyncio) to versions requiring 3.9+ - Removes 3.8 from the CI test matrix and nox PYTHON_VERSIONS - Keeps requires-python = ">=3.8" so end users on 3.8 can still install via pip (which resolves independently) - Keeps 3.8 in the smoke-test matrix (no lockfile needed) - Adds renovate packageRule to prevent bumping the pyjwt 3.8 marker line Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
can't really do this without a major version bump of the SDK |
Contributor
Greptile SummaryThis PR drops Python 3.8 from the development environment and CI test matrix while preserving backward compatibility for end users. Python 3.8 reached EOL in October 2024, and dev dependencies (pytest, mypy, pytest-asyncio) are dropping 3.8 support, causing all Renovate PRs to fail. Key Changes:
Impact:
Confidence Score: 5/5
Important Files Changed
Flowchartflowchart TD
A[Python 3.8 EOL Oct 2024] --> B{Problem: Dev dependencies<br/>dropping 3.8 support}
B --> C[Renovate PRs failing:<br/>pytest, mypy, etc.]
C --> D[uv resolves for ALL versions<br/>including 3.8]
D --> E[Solution: Add environments filter<br/>to pyproject.toml]
E --> F[tool.uv environments =<br/>python_version >= 3.9]
F --> G[Remove 3.8 from<br/>CI test matrix]
F --> H[Remove 3.8 from<br/>nox PYTHON_VERSIONS]
F --> I[Regenerate uv.lock<br/>without 3.8 splits]
F --> J[Add Renovate rule to<br/>freeze pyjwt 2.9.x]
G --> K[Tests run on 3.9-3.14 only]
H --> K
I --> L[Lockfile only resolves<br/>for Python 3.9+]
J --> M[Keep pyjwt marker for<br/>3.8 pip users]
K --> N{Result}
L --> N
M --> N
N --> O[Dev dependencies work<br/>Renovate PRs unblocked]
N --> P[3.8 users can still<br/>pip install via PyPI]
style A fill:#ffcccc
style E fill:#ccffcc
style N fill:#cceeff
style O fill:#ccffcc
style P fill:#ccffcc
Last reviewed commit: f6210d5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All 7 failing Renovate PRs (#528, #529, #531, #534, #545, #546) share the same root cause:
requires-python = ">=3.8"forces uv to resolve dependencies for ALL Python versions including 3.8. When Renovate bumps a dev dependency (pytest, mypy, pytest-asyncio) to a version that dropped Python 3.8 support,uv sync --locked --devfails.Python 3.8 reached EOL in October 2024. This fix:
environments = ["python_version >= '3.9'"]to[tool.uv]so the lockfile only resolves for Python 3.9+, unblocking Renovate PRsPYTHON_VERSIONSrequires-python = ">=3.8"so end users on 3.8 can still install via pip (which resolves independently)packageRuleto prevent Renovate from bumping the pyjwt 3.8 marker line in the futureTest plan
uv locksucceeds without 3.8 resolution splitsuv sync --devinstalls all dev dependenciesuv run pytestmaininto each failing Renovate PR branch +uv lockto unblock them🤖 Generated with Claude Code