Conversation
- Fix MetPy description: `tCollection...` -> t`Collection...` (stray t inside backticks) - Fix footer copyright: "Apache 2.0Licensed." -> "Apache 2.0 Licensed." (missing space) - Wrap remaining unwrapped project descriptions and domains for translation (hvPlot, Pangeo, cf-xarray, omfit, sgkit, xmip) - Also fix double space in cf-xarray description Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- features.js: Wrap "Arbitrary metadata tracking" text - repl.js: Wrap "Try Xarray" heading - donate.js: Wrap "501(c)(3) nonprofit charity" link text - timeline-plot-container.js: Wrap "Issues" tab and include end date inside translation string Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The useMemo with empty deps ([]) caches data from the first render and never updates. When the locale changes, the data functions return new translated strings but useMemo returns the stale cached values. Since these data functions are cheap to call, just remove useMemo. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
These pages use translated strings but had no getStaticProps calling loadCatalog, so translations wouldn't load on direct page access or SSR in non-English locales. Also wraps the team page title for translation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Concatenating translated fragments with regular strings (e.g. value + t\`hours\`) prevents translators from reordering the full phrase. Use single t\`...\` tagged templates with interpolations so translators see the complete string. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
These pages intentionally don't load translations (blog content is not translated), so the import is dead code. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for xarraydev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Run lingui extract + compile to add catalog entries for newly wrapped strings. Without this, Lingui shows internal message ID hashes instead of the actual text. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
seems to have fixed some of the issues: https://deploy-preview-828--xarraydev.netlify.app/pt/team |
Contributor
Author
|
I'm going to merge this asap because there are some very clearly broken pages on the website which deserve fixing. but I'd love to hear if my changes the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several nitpicky follow up issues (found by cluade) as a follow up to #772
trelative to the backtickton part of itloadCatalogheads up @melissawm these are teh issues i was referring to.
to get the new translations to show up properly in english i had to run: