auth: Use webcrypto & Uint8Array instead of NodeJS crypto & Buffer#77
Open
dwardu wants to merge 2 commits intoxdevplatform:mainfrom
Open
auth: Use webcrypto & Uint8Array instead of NodeJS crypto & Buffer#77dwardu wants to merge 2 commits intoxdevplatform:mainfrom
dwardu wants to merge 2 commits intoxdevplatform:mainfrom
Conversation
|
|
|
Hi... I want to recover my account. I think I unintentionally broke the Twitter Rules, but after reading it and reading it again well; I undertake not to violate and comply with all laws and policies of use of the Twitter program. I undertake to abide by the laws and thank you for your cooperation Note I have worked with you a lot on recalculation. Please I want to understand what are your conditions for reinstatement of these accounts mentioned below 👇👇👇👇 @chinanws22 @WORLD___2022 @chinewar111 |
dwardu
changed the title
dwardu
changed the title
|
I can confirm this works as expected, are there any plans to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current
authimplementation makes use of NodeJScryptopackage andBuffer, and because of this the library cannot be used in contexts where these are unavailable, such as on Cloudflare workers.Solution
The solution was to replace NodeJS primitives with their standard counterparts.
Result
As a result of the changes in this PR, it will be possible to use the library on environments where NodeJS
cryptoandBufferare not available, such as Cloudflare workers.