Skip to content

Add worker-loader #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TimDaub wants to merge 9 commits into from
Closed

Add worker-loader #815

TimDaub wants to merge 9 commits into from

Conversation

@TimDaub
Copy link
Contributor

@TimDaub TimDaub commented Mar 4, 2021

Few comments

🤞🏼 that somehow this gets merged!

@schlusslicht @TimDaub
Add worker-loader
1e4d012 
Targets enhancement: developit#170
Enable usage of `microbundle --worker-loader` to apply rollup-plugin-web-worker-loader.

Allow bundling web workers automatically

- Add flag `--worker-loader`
- For format `es` and `modern`, a Worker `type: module` is automatically
bundled
@changeset-bot
Copy link

changeset-bot bot commented Mar 4, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: f155eee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TimDaub TimDaub mentioned this pull request Mar 4, 2021
Open
developit
developit reviewed May 5, 2021
View reviewed changes
developit
developit reviewed May 5, 2021
View reviewed changes
@TimDaub TimDaub requested a review from developit May 5, 2021 20:16
@TimDaub
Copy link
Contributor Author

TimDaub commented May 5, 2021

@developit I addressed your comments. I'm not sure I'm capable of rebasing though. Last time I tried sketchy things happened in package-lock.json that I wasn't able to address. What now?

@ForsakenHarmony
Copy link
Collaborator

ForsakenHarmony commented May 26, 2021

Last time I tried sketchy things happened in package-lock.json that I wasn't able to address.

You generally have to accept the remote one and then after create a new commit / amend a commit with a file you generated after by running npm install

@developit
Copy link
Owner

developit commented May 27, 2021

I'll try to get this rebased this week (I'm also terrible at it!).

This will need to go into a new breaking release (minor since microbundle is still pre-1.0), but I think that should be fine.

@developit
Copy link
Owner

developit commented Jun 7, 2021

Just wanted to mention I haven't forgotten about this PR, I just have been side-tracked rewriting Microbundle's filename inference.

@marcbouchenoire marcbouchenoire mentioned this pull request Jul 20, 2021
Merged
@developit
Copy link
Owner

developit commented Oct 6, 2021

This was landed in #867! 🎉

@developit developit closed this Oct 6, 2021
@developit developit mentioned this pull request Oct 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@developit developit developit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

scriptURL of serviceWorker.register isn't considered part of bundle

4 participants

@TimDaub @ForsakenHarmony @developit @schlusslicht